Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: sync store config in time (#6919) #6932

Merged
merged 5 commits into from
Aug 14, 2023
Merged

config: sync store config in time (#6919) #6932

merged 5 commits into from
Aug 14, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6919

What problem does this PR solve?

Issue Number: Close #6918

What is changed and how does it work?

add timeout context for observer tikv config to avoid wait too long

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

sync store config in time

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 10, 2023
Merged
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 10, 2023
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and rleungx August 10, 2023 05:34
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 10, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 10, 2023
@bufferflies
resolve conflict
9dbc9bf 
Signed-off-by: bufferflies <[email protected]>
@bufferflies bufferflies force-pushed the cherry-pick-6919-to-release-6.5 branch from dad9427 to 9dbc9bf Compare August 14, 2023 08:32
@codecov
Copy link

codecov bot commented Aug 14, 2023 •
edited
Loading

Codecov Report

Patch coverage: 82.35% and project coverage change: +0.07% 🎉

Comparison is base (3a19dec) 75.59% compared to head (90d4386) 75.67%.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-6.5    #6932      +/-   ##
===============================================
+ Coverage        75.59%   75.67%   +0.07%     
===============================================
  Files              328      328              
  Lines            33199    33211      +12     
===============================================
+ Hits             25097    25131      +34     
+ Misses            5947     5927      -20     
+ Partials          2155     2153       -2
Flag Coverage Δ
unittests 75.67% <82.35%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
server/config/store_config.go 80.43% <71.42%> (-1.18%) ⬇️
server/cluster/cluster.go 81.50% <90.00%> (-0.06%) ⬇️

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 14, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 14, 2023
@bufferflies
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 14, 2023

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 14, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 90d4386

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 14, 2023
@ti-chi-bot ti-chi-bot bot merged commit 9a9fc0f into tikv:release-6.5 Aug 14, 2023
17 checks passed
@HuSharp HuSharp deleted the cherry-pick-6919-to-release-6.5 branch August 22, 2023 05:19
@HuSharp HuSharp mentioned this pull request Aug 22, 2023
Merged
17 tasks
@AndreMouche AndreMouche mentioned this pull request Mar 21, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp approved these changes

@rleungx rleungx rleungx approved these changes

@HunDunDM HunDunDM Awaiting requested review from HunDunDM

Assignees

@bufferflies bufferflies

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @bufferflies @rleungx @HuSharp